TEST: Remove deterministic temporal and rolling skips - #24015
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 12 included reviews per hour; 5 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe test suite now parameterizes supported timedelta, datetime, and rolling operations explicitly. Runtime skips for unsupported operations and invalid rolling combinations were removed. Rolling variance and standard deviation tests reuse module-scoped fixtures. ChangesSupported operation test coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This updates test collection to run supported temporal and rolling cases directly while reusing deterministic rolling inputs. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
/ok to test |
|
/ok to test |
bdice
left a comment
There was a problem hiding this comment.
Approving but not merging, see comment.
| pytest.skip(f"{reduction_methods} not implemented") | ||
| return reduction_methods | ||
| @pytest.fixture(params=["min", "max", "sum", "std", "var"]) | ||
| def supported_rolling_reductions(request): |
There was a problem hiding this comment.
The negative filter with explicit skips made it easier to see gaps in functionality. Not a blocker, just raising that for awareness.
Description
Replace temporal, reduction, and rolling parameter combinations that deterministically skipped before an assertion with their existing supported subsets. Every combination that previously ran, including its expected failures and warning checks, still runs. The rolling variance/std inputs are additionally module-scoped and read-only, so option variants reuse identical data rather than reconstructing it.
Checklist