TEST: Reuse I/O test fixtures - #24012
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughChangesThe input/output test modules now reuse module-scoped fixtures. JSON and Parquet tests isolate mutations by copying pandas inputs. ORC list tests use named data cases and a shared builder. Input/output test maintenance
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This updates test-fixture reuse and lazy ORC test-data construction without changing product behavior or stated test coverage. No merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
/merge |
Description
Make shared I/O source data module-scoped, and construct the expensive ORC nested-list data only for the selected parameterized case.
The fixtures are read-only to surrounding tests; the two tests that mutate a pandas frame now copy it first. All original formats, assertions, and parameterized I/O cases remain executed unchanged.
Checklist