Skip to content

CI: Measure complete PR workflow timing - #24007

Draft
vyasr wants to merge 7 commits into
NVIDIA:mainfrom
vyasr:codex/measure-full-pr-workflow
Draft

CI: Measure complete PR workflow timing#24007
vyasr wants to merge 7 commits into
NVIDIA:mainfrom
vyasr:codex/measure-full-pr-workflow

Conversation

@vyasr

@vyasr vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Description

Temporary comment-only markers that intentionally exercise every path-filtered PR job. This draft PR exists solely to collect a current complete-workflow timing baseline; it has no functional effect.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue cudf.pandas Issues specific to cudf.pandas labels Sep 6, 2026
@vyasr

vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

/ok to test

@vyasr, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@vyasr vyasr added the ci label Sep 6, 2026
@vyasr

vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

/ok to test

@vyasr, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@vyasr
vyasr marked this pull request as ready for review September 6, 2026 16:17
@vyasr
vyasr requested review from a team as code owners September 6, 2026 16:17
@vyasr

vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

/ok to test

@vyasr, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 394c30d9-4336-4a8d-b81d-d280a70b1d69

📥 Commits

Reviewing files that changed from the base of the PR and between c6af384 and d8b3714.

📒 Files selected for processing (1)
  • .github/workflows/pr.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Streamlined pull-request validation by running only the affected C++ and Python test subsets.
    • Added independent controls for selected test suites, allowing unaffected suites to be skipped.
    • Expanded Pandas test execution from two shards to three, improving parallel coverage and reducing per-shard workload.

Walkthrough

The PR workflow maps changed files to component-specific C++ and Python test suites. Test scripts use environment flags to skip unaffected suites. Pandas tests use three shards, and temporary timing markers were added.

Changes

Component-specific test selection

Layer / File(s) Summary
Route changed files to test suites
.github/workflows/pr.yaml
The workflow defines separate C++ and Python component groups. Test jobs pass matching RUN_*_TESTS flags to the test scripts.
Conditionally execute test suites
ci/test_cpp.sh, ci/test_python_other.sh
C++ and Python test suites default to enabled and run only when their corresponding flags are true. C++ suites retain prior-success gating.
Update timing markers and Pandas sharding
.github/workflows/pr.yaml, cpp/CMakeLists.txt, python/cudf/cudf/pandas/__init__.py, python/dask_cudf/README.md
Temporary no-op markers were added. The SPDX header spacing was adjusted. Pandas test sharding increased from two shards to three.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to d8b37

This change adds CI timing markers, splits CI test selection by component, and increases Pandas test sharding to three. No concrete merge-blocking risk is identified in the supplied current-head evidence.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI workflow timing measurement, which matches the primary purpose of the changes.
Description check ✅ Passed The description accurately explains that temporary markers exercise path-filtered PR jobs to measure a complete workflow timing baseline without functional changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vyasr

vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 5a3d137

@vyasr
vyasr marked this pull request as draft September 6, 2026 16:20
@vyasr
vyasr marked this pull request as ready for review September 6, 2026 17:34
@vyasr

vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 5bb3d3a

@vyasr
vyasr marked this pull request as draft September 6, 2026 17:34
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 6, 2026
@vyasr
vyasr marked this pull request as ready for review September 6, 2026 18:20
@vyasr

vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test c6af384

@vyasr
vyasr marked this pull request as draft September 6, 2026 18:21
@vyasr
vyasr marked this pull request as ready for review September 6, 2026 18:23
@vyasr

vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test c6af384

@vyasr
vyasr marked this pull request as draft September 6, 2026 18:24
@vyasr
vyasr marked this pull request as ready for review September 6, 2026 19:20
@vyasr

vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test d8b3714

@vyasr
vyasr marked this pull request as draft September 6, 2026 19:21
@vyasr
vyasr marked this pull request as ready for review September 6, 2026 22:04
@vyasr

vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 9393024

@vyasr
vyasr marked this pull request as draft September 6, 2026 22:05
@vyasr
vyasr marked this pull request as ready for review September 6, 2026 22:08
@vyasr

vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 9393024

@vyasr
vyasr marked this pull request as draft September 6, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CMake CMake build issue cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant