Adopt CUDA stream compatibility accessors - #23995
Open
bdice wants to merge 3 commits into
Open
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
19 tasks
github-actions
Bot
added
libcudf
3 tasks
bdice
force-pushed
the
cuda-stream-ref-prep
branch
from
September 6, 2026 14:30
d606153 to
920fca8
Compare
bdice
force-pushed
the
cuda-stream-ref-prep
branch
from
September 7, 2026 01:07
920fca8 to
ac9f158
Compare
bdice
added
improvement
bdice
marked this pull request as ready for review
September 8, 2026 20:15
bdice
requested review from
TomAugspurger,
nirandaperera,
shrshi and
thirtiseven
September 8, 2026 20:15
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (104)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe pull request replaces deprecated CUDA stream headers and ChangesCUDA stream API migration
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to This change updates CUDA stream handle extraction to the compatible get() accessor and replaces deprecated stream headers without changing public APIs or stream selection. No concrete current-head merge risk remains. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 14 files. (90 skipped: 90 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the
get()compatibility alias added in RMM #2537. This spelling is shared byrmm::cuda_stream_viewandcuda::stream_ref.This preserves existing stream types and public APIs while extracting mechanical accessor updates from the broader stream migration. It is independently buildable without RMM #2372 and leaves the migration PR focused on actual type and signature changes.
This updates raw stream extraction at Cython boundaries and uses the CUDA stream umbrella header where stream definitions are required, without changing libcudf stream types or public APIs. The remaining type, construction, and forwarding changes stay in cuDF #23929.
Checklist