Update nvCOMP adapter - #23993
Draft
vuule wants to merge 2 commits into
Draft
Conversation
Newer nvCOMP releases rename the host-only batched temp size queries and give them a trailing stream parameter, which the library uses to identify the device whose properties determine the temp size. Wrap the call in a macro so both spellings build, and thread a stream down from the existing call sites, all of which already had one available.
nvCOMP's package version file only accepts requests with a matching major version, so a versioned find_package can never span both 5.x and 6.x. Search without a version constraint and check the result against the supported range instead.
github-actions
Bot
added
libcudf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the nvCOMP adapter to match the API changes in nvCOMP: the batched temp size queries lost their
Asyncsuffix and gained a stream parameter, which the library uses to identify the device whose properties determine the temp size.Also relaxes the CMake search so that newer installed nvCOMP versions are accepted.
Checklist