Skip to content

[FEA] Remove precompiled header directory specifications #23987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Sep 8, 2026
+0 −10
Merged

[FEA] Remove precompiled header directory specifications #23987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cpp/src/jit/cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,6 @@ rtcx::blob compile_fragment(char const* name,
auto& bundle = ctx.jit_bundle();

auto include_dirs = bundle.get_include_directories();
auto pch_dir = ctx.get_jit_pch_dir();

auto nvrtc_version = ctx.nvrtc_version().value();

Expand Down Expand Up @@ -333,7 +332,6 @@ rtcx::blob compile_fragment(char const* name,

if (use_pch) {
options.emplace_back("--pch");
options.emplace_back(std::format("--pch-dir={}", pch_dir));

if (cfg.jit_verbose) {
options.emplace_back("--pch-verbose=true");
Expand Down
5 changes: 0 additions & 5 deletions cpp/src/runtime/context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ void context::initialize_jit()
// make sure the required directories exist
std::filesystem::create_directories(_config.rtcx_cache_dir);
std::filesystem::create_directories(_config.jit_bundle_dir);
std::filesystem::create_directories(_config.jit_pch_dir);
std::filesystem::create_directories(_config.jit_tmp_dir);

_nvrtc_version = rtcx::nvrtc_version();
Expand Down Expand Up @@ -117,8 +116,6 @@ bool context::use_jit() const { return _config.use_jit; }

context_config const& context::config() const { return _config; }

std::string const& context::get_jit_pch_dir() const { return _config.jit_pch_dir; }

context::device_properties const& context::get_device_properties() const
{
return _device_properties;
Expand Down Expand Up @@ -229,7 +226,6 @@ context make_context(detail::init_flags flags)
auto const cache_dir = get_cudf_kernel_cache_dir();
auto const jit_bundle_dir = cache_dir / "bundle";
auto const rtcx_cache_dir = cache_dir / "rtcx_cache";
auto const jit_pch_dir = cache_dir / "pch";
auto const jit_tmp_dir = cache_dir / "tmp";

flags = flags | (preload_nvcomp ? detail::init_flags::LOAD_NVCOMP : detail::init_flags::NONE);
Expand All @@ -245,7 +241,6 @@ context make_context(detail::init_flags flags)
.dump_jit_time_profile = dump_jit_time_profile,
.rtcx_cache_dir = rtcx_cache_dir,
.jit_bundle_dir = jit_bundle_dir,
.jit_pch_dir = jit_pch_dir,
.jit_tmp_dir = jit_tmp_dir,
.kernel_cache_limit_process = kernel_cache_limit_process};

Expand Down
3 changes: 0 additions & 3 deletions cpp/src/runtime/context.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ struct [[nodiscard]] context_config {
bool dump_jit_time_profile : 1 = false;
std::string rtcx_cache_dir = {};
std::string jit_bundle_dir = {};
std::string jit_pch_dir = {};
std::string jit_tmp_dir = {};
uint32_t kernel_cache_limit_process = 0;
};
Expand Down Expand Up @@ -84,8 +83,6 @@ class context {

[[nodiscard]] context_config const& config() const;

[[nodiscard]] std::string const& get_jit_pch_dir() const;

[[nodiscard]] device_properties const& get_device_properties() const;

[[nodiscard]] std::optional<int32_t> nvrtc_version() const;
Expand Down
Loading