Hi en fixes - #476
Open
mayuris-00 wants to merge 1 commit into
Open
Conversation
mayuris-00
force-pushed
the
hi-en-fixes
branch
from
August 20, 2026 07:51
56c241e to
66b9c1f
Compare
mayuris-00
marked this pull request as ready for review
August 20, 2026 07:55
Signed-off-by: Mayuri S <mayuris@nvidia.com>
mayuris-00
force-pushed
the
hi-en-fixes
branch
from
September 1, 2026 08:04
40de834 to
c45c655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Three small fixes to the Hindi ITN grammar, plus hi_en test coverage.
The table already had मील प्रति सेकंड and मील प्रति घंटा but not the metre,
kilogram or litre equivalents, so the unit converted while प्रति X stayed as words.
graph_digit covers only १ to ९, so शून्य बजकर तीस मिनट could not parse as a time
and fell to the measure grammar as ० बजकर ३० m. Now returns ०:३०.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.