Created cardinal Semiotic class for Kannada TN - #448
Conversation
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
…iles Signed-off-by: richa-2002 <richa@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
9149d5a to
53b3447
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: richa-2002 <richa@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: richa-2002 <richa@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: richa-2002 <richa@nvidia.com>
|
Hi @folivoramanh , I have addressed all the changes you suggested. |
|
|
||
| def __init__(self, deterministic: bool = True): | ||
| super().__init__(name="punctuation", kind="classify", deterministic=deterministic) | ||
| s = "!#%&\'()*+,-./:;<=>?@^_`{|}~\"" |
There was a problem hiding this comment.
does the language need any additional punctuation?
There was a problem hiding this comment.
I don’t think any additional punctuation is needed for Kannada, as it follows the same standard punctuation conventions as Hindi.
There was a problem hiding this comment.
and do these symbols cover all Hindi/Kannada punctuation?
| class VerbalizeFinalFst(GraphFst): | ||
| """ | ||
| Finite state transducer that verbalizes an entire sentence, e.g. | ||
| tokens { name: "its" } tokens { time { hours: "twelve" minutes: "thirty" } } tokens { name: "now" } tokens { name: "." } -> its twelve thirty now . |
There was a problem hiding this comment.
let's have all definitions be in the language
There was a problem hiding this comment.
Yes. I've referred to the Spanish implementation and removed the English example . I didn't replace it with a direct Kannada translation because the resulting sentence would not have natural Kannada wording.
There was a problem hiding this comment.
ok, let's instead use a natural Kannada sentence and make sure that the full structure matches what the verbalizer_final output outputs
| @@ -0,0 +1,57 @@ | |||
| 4 ಚೌಕೆ~ನಾಲ್ಕು ಚೌಕೆ | |||
There was a problem hiding this comment.
are all rule categories covered here? at the very least I see negatives missing
There was a problem hiding this comment.
Yes, I’ve added negative test cases and reviewed the test cases to ensure that the different rule categories are covered.
Signed-off-by: richa-2002 <richa@nvidia.com>
for more information, see https://pre-commit.ci
|
Thank you for the review, @mgrafu. I have addressed all the changes you suggested. Additionally, I removed the unnecessary weights from cardinal.py file from tagger module. Testing |
3 participants
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.