Add missing version selector for 2.1.1#6396
Conversation
7c48c04 to
13f10a0
Compare
|
!build |
|
| Filename | Overview |
|---|---|
| docs/conf.py | Adds 2.1.1 patch version to the version-switcher list, but uses "dali_2.1.1" (dots) as the archive path identifier instead of the correct "dali_2_1_1" (underscores), producing a broken URL. URL validation is also bypassed for this entry at build time. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[versions list built] --> B[append 2.1.1 entry
'dali_2.1.1' dots used]
B --> C[versions sorted descending
by Version number]
C --> D[json_data built with URLs
using archive identifier]
D --> E[json_data trimmed to 10]
E --> F{URL validation loop}
F -->|index == 2 SKIP| G[2.1.1 entry at index 2
URL never validated]
F -->|other indices| H[HEAD request to URL]
H -->|status >= 400| I[exit 1]
H -->|status < 400| J[OK]
G --> K[switcher.json written with
broken dali_2.1.1 URL]
J --> K
Reviews (2): Last reviewed commit: "Add missing version selector for 2.1.1" | Re-trigger Greptile
| for i in range(0, v_minor + correction): | ||
| versions.append((f"{v_major}.{i}", f"dali_{v_major}_{i}_0", "short_user")) | ||
|
|
||
| versions.append(("2.1.1", "2.1.1", "short_user")) |
There was a problem hiding this comment.
[Question] Archive path uses bare version string, not
dali_ convention
Every other patch release uses the dali_x_y_z identifier as the archive path segment — e.g. ("1.37.1", "dali_1_37_1", "short_user") and ("1.11.1", "dali_1_11_1"). Regular minor releases use the same pattern via the loop: f"dali_{v_major}_{i}_0". Here, the second tuple element is "2.1.1" (the bare version string), which causes the short_user branch to generate the URL https://docs.nvidia.com/deeplearning/dali/archives/2.1.1/user-guide/ instead of the pattern-consistent https://docs.nvidia.com/deeplearning/dali/archives/dali_2_1_1/user-guide/. URL validation in conf.py explicitly skips index 2 (which this entry occupies after sorting), so a broken link would not be caught at build time. Can you confirm the exact archive path used for the 2.1.1 docs?
|
CI MESSAGE: [54861749]: BUILD STARTED |
- adds missing version selector for DALI patch release 2.1.1 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
13f10a0 to
489fd50
Compare
|
!build |
|
CI MESSAGE: [54862240]: BUILD STARTED |
|
CI MESSAGE: [54862240]: BUILD PASSED |
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A