Skip to content

fix: system detection breaks on first non-empty result dict - #97

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/parse-results-3d10429c
Open

fix: system detection breaks on first non-empty result dict#97
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/parse-results-3d10429c

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026

Copy link
Copy Markdown

Problem

fix: system detection breaks on first non-empty result dict

Fix

Replace:

    for result in [read_bw, read_iops, read_125k_bw, max_bw, dali_results,
                   metadata]:
        try:
            total_systems = max(result.keys())
            systems = sorted(result.keys())
        except ValueError:
            continue
        else:
            break

with:

    all_systems = set()
    for result in [read_bw, read_iops, read_125k_bw, max_bw, dali_results,
                   metadata]:
        all_systems.update(result.keys())
    total_systems = max(all_systems) if all_systems else 0
    systems = sorted(all_systems)

Files changed

  • bobber/lib/analysis/parse_results.py

@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review July 28, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant