Skip to content

fix(fio): IOPS parser drops decimal values with '\d+' regex (+1 more) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(fio): IOPS parser drops decimal values with '\d+' regex (+1 more) #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bobber/lib/analysis/fio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def clean_iops(iops: str) -> float:
float
Returns a ``float`` of the final IOPS value in operations/second.
"""
number = float(re.findall(r'\d+', iops)[0])
number = float(re.findall(r'[-+]?\d+(?:\.\d+)?', iops)[0])
if 'G' in iops:
ops_per_second = number * 1e9
elif 'M' in iops:
Expand Down Expand Up @@ -249,8 +249,12 @@ def parse_fio_iops_file(log_files: list, systems: int,
write_params)
write_iops = fio_iops_results(log_contents, systems, 'write: IOPS=.*',
log)
if write_iops == []:
continue
read_iops = fio_iops_results(log_contents, systems, 'read: IOPS=.*',
log)
if read_iops == []:
continue
write_system_results[systems].append(sum(write_iops))
read_system_results[systems].append(sum(read_iops))
return read_system_results, write_system_results, read_params, write_params