Skip to content

fix: DALI warmup slicing can leave empty list before min() #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: DALI warmup slicing can leave empty list before min() #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bobber/lib/analysis/dali.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,12 @@ def _result_parsing(log_contents: str, systems: int, image_results: dict,
# be off, and one node will showcase the 2nd test pass before all nodes
# have finished the first. To accomodate for this, the lowest N results
# are assumed to be the first test pass and are dropped.
all_speeds = sorted(all_speeds)[systems:]
all_speeds = sorted(all_speeds)
if len(all_speeds) <= systems:
print(f'Warning: Not enough DALI speed samples in {log_file}; '
'skipping...')
return {}
all_speeds = all_speeds[systems:]
image_type_match[num] = _update_results(image_type_match[num],
all_speeds)

Expand Down