Skip to content

fix(compare-baseline): exact baseline matches should pass (+1 more) #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(compare-baseline): exact baseline matches should pass (+1 more) #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion bobber/lib/analysis/compare_baseline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def metric_passes(expected: float, got: float, tolerance: int) -> bool:
# If user passes a 5% tolerance, multiply the expected value by 5% less
# than current value to get the tolerance.
expected = (1 - tolerance / 100) * expected
if got > expected:
if got >= expected:
return True
else:
return False
Expand Down Expand Up @@ -250,8 +250,16 @@ def evaluate_test(baseline: dict, results: dict, system_count: int,
failures = evaluate_fio(test_values, results, test_name, failures,
tolerance)
elif test_name == 'nccl':
if test_name not in results:
print(f' {TEST_MAPPING[test_name]}')
print(' No NCCL results found, skipping...')
continue
failures = evaluate_nccl(test_values, results, failures, tolerance)
elif test_name == 'dali':
if test_name not in results:
print(f' {TEST_MAPPING[test_name]}')
print(' No DALI results found, skipping...')
continue
failures = evaluate_dali(test_values,
results['dali'],
test_name,
Expand Down