fix(common): undefined log variable in (+2 more)

[andrewwhitecdw]

This PR addresses 3 issues in bobber/lib/analysis/common.py.

Fix 1

fix: undefined log variable in fio_command_details error

Fix: Replace:

    if len(commands) < 2:
        raise ValueError(f'FIO command not found in {log} file!')

with:

    if len(commands) < 2:
        raise ValueError('FIO command not found in log contents!')

Fix 2

fix: catch IndexError when system count pattern is missing

Fix: Replace:

    try:
        systems = re.findall(r'systems_\d+_', log)
        systems = re.findall(r'\d+', systems[0])
        return int(systems[0])
    except ValueError:
        return None

with:

    try:
        systems = re.findall(r'systems_\d+_', log)
        systems = re.findall(r'\d+', systems[0])
        return int(systems[0])
    except (IndexError, ValueError):
        return None

Fix 3

fix: handle unrecognized units in _convert_to_bytes

Fix: Replace:

    elif 'k' in value.lower():
        return number * 1e3

with:

    elif 'k' in value.lower():
        return number * 1e3
    raise ValueError(f'Unknown unit in value: {value}')

Files changed

• bobber/lib/analysis/common.py