Skip to content

fix(setup-fio): ssh options placed after host in drop_caches (+1 more) - #101

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/setup-fio-assorted-3acb6dd4
Open

fix(setup-fio): ssh options placed after host in drop_caches (+1 more)#101
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/setup-fio-assorted-3acb6dd4

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026

Copy link
Copy Markdown

This PR addresses 2 issues in bobber/test_scripts/setup_fio.sh.

Fix 1

fix: ssh options placed after host in drop_caches

Fix: Replace:

            ssh $N $SSHOPTS /sbin/sysctl vm.drop_caches=3 &

with:

            ssh ${SSHOPTS} $N /sbin/sysctl vm.drop_caches=3 &

Fix 2

fix: stop_servers pid handling and localhost killall

Fix: Apply patch:

--- a/bobber/test_scripts/setup_fio.sh
+++ b/bobber/test_scripts/setup_fio.sh
@@ -32,7 +32,7 @@
 stop_servers () {
 
     declare -a pidlist
-    pidlist=""
+    pidlist=()
     for N in $FIO_NODELIST; do
         echo "Killing Server on $N"
 
	    if [ "$N" == "localhost" ]; then
-	        killall fio
+	        killall fio &
         else
             ssh ${SSHOPTS} $N killall fio > /dev/null 2>&1 &
	    fi

Files changed

  • bobber/test_scripts/setup_fio.sh

@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review July 28, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant