Skip to content

docs: fix dataset_name override path in grpo task mapping note#2836

Open
yuki-97 wants to merge 1 commit into
mainfrom
docs/fix-dataset-name-override-path
Open

docs: fix dataset_name override path in grpo task mapping note#2836
yuki-97 wants to merge 1 commit into
mainfrom
docs/fix-dataset-name-override-path

Conversation

@yuki-97

@yuki-97 yuki-97 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix one outdated config path reference in the GRPO task–dataset mapping note: config.data.dataset_nameconfig.data.train.dataset_name. Training configs nest dataset_name under data.train (see examples/configs/grpo_math_8B.yaml, sft_openmathinstruct2.yaml), so the previous wording would silently mislead anyone using it as a Hydra override.

Closes #2719.

Note on eval docs

Eval configs (examples/configs/evals/*.yaml) use a flat data.dataset_name key with no train sub-key — see eval.yaml, gpqa_eval.yaml, math_eval.yaml, mmau.yaml, etc. So all eval-context references in the docs (docs/guides/eval.md, docs/about/evaluation.md, the eval section of docs/guides/grpo-audio.md, and the run_eval.py example in docs/guides/sft-openmathinstruct2.md) are correct as-is and intentionally left unchanged.

Of the 11 data.dataset_name= occurrences in docs/, 10 are eval (correct) and only the one in docs/guides/grpo.md describes training (incorrect, now fixed).

Test plan

  • Docs-only change; no runtime impact.

Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97 yuki-97 requested a review from a team as a code owner June 16, 2026 08:15
@copy-pr-bot

copy-pr-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the Documentation Improvements or additions to documentation label Jun 16, 2026
@yuki-97 yuki-97 added the CI:docs Run doctest label Jun 16, 2026
@yuki-97

yuki-97 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 40f39af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:docs Run doctest Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRAIN-3] Hydra override path data.dataset_name is incorrect; should be data.train.dataset_name

1 participant