docs: fix dataset_name override path in grpo task mapping note#2836
Open
yuki-97 wants to merge 1 commit into
Open
docs: fix dataset_name override path in grpo task mapping note#2836yuki-97 wants to merge 1 commit into
yuki-97 wants to merge 1 commit into
Conversation
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Contributor
Author
|
/ok to test 40f39af |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.data.dataset_name→config.data.train.dataset_name. Training configs nestdataset_nameunderdata.train(seeexamples/configs/grpo_math_8B.yaml,sft_openmathinstruct2.yaml), so the previous wording would silently mislead anyone using it as a Hydra override.Closes #2719.
Note on eval docs
Eval configs (
examples/configs/evals/*.yaml) use a flatdata.dataset_namekey with notrainsub-key — seeeval.yaml,gpqa_eval.yaml,math_eval.yaml,mmau.yaml, etc. So all eval-context references in the docs (docs/guides/eval.md,docs/about/evaluation.md, the eval section ofdocs/guides/grpo-audio.md, and therun_eval.pyexample indocs/guides/sft-openmathinstruct2.md) are correct as-is and intentionally left unchanged.Of the 11
data.dataset_name=occurrences indocs/, 10 are eval (correct) and only the one indocs/guides/grpo.mddescribes training (incorrect, now fixed).Test plan