Skip to content

fix: cube-sphere communitcator rank limits#491

Merged
romanc merged 1 commit into
NOAA-GFDL:developfrom
romanc:opt_merge/comm-rank-limit
Jul 1, 2026
Merged

fix: cube-sphere communitcator rank limits#491
romanc merged 1 commit into
NOAA-GFDL:developfrom
romanc:opt_merge/comm-rank-limit

Conversation

@romanc

@romanc romanc commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Description

Weaken the cube-sphere communicator hard ranks limit. We need "at least" not "exactly" the rank number. Iirc this has especially been an issue with "io rank" when running integrated into GEOS.

This is part of building back the "opt_cycle_I"-branch, i.e. trying to get #465 into a smaller changeset.

How has this been tested?

Running dynamics as part of the June push. @FlorianDeconinck is there an easy way to test this?

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/): N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
    ???

@romanc romanc requested a review from FlorianDeconinck June 30, 2026 15:35
@FlorianDeconinck

Copy link
Copy Markdown
Collaborator

Not really a good way to test this, apart from a mock MPI and a rather silly test. It is a very "operation" oriented case where you oversubscribe your nodes because you need IO to get nodes, but since we are below the infrastructure layer we can reason on the all structure

@FlorianDeconinck FlorianDeconinck left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanc

romanc commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

Alright - in that case, let's just merge as-is saying that we've tested (extensively) with recent runs integrated in GEOS (which is the final bar anyway).

@romanc romanc added this pull request to the merge queue Jul 1, 2026
Merged via the queue into NOAA-GFDL:develop with commit 06c61b8 Jul 1, 2026
9 of 10 checks passed
@romanc romanc deleted the opt_merge/comm-rank-limit branch July 1, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants