fix: cube-sphere communitcator rank limits#491
Merged
Conversation
…st" not "exactly" the rank number
Collaborator
|
Not really a good way to test this, apart from a mock MPI and a rather silly test. It is a very "operation" oriented case where you oversubscribe your nodes because you need IO to get nodes, but since we are below the infrastructure layer we can reason on the all structure |
Collaborator
Author
|
Alright - in that case, let's just merge as-is saying that we've tested (extensively) with recent runs integrated in GEOS (which is the final bar anyway). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Weaken the cube-sphere communicator hard ranks limit. We need "at least" not "exactly" the rank number. Iirc this has especially been an issue with "io rank" when running integrated into GEOS.
This is part of building back the "opt_cycle_I"-branch, i.e. trying to get #465 into a smaller changeset.
How has this been tested?
Running dynamics as part of the June push. @FlorianDeconinck is there an easy way to test this?
Checklist
???