[feature/capgen-v1]: Test for issue 772 in capgen v0, fix for issue 774 (name collision in capgen v1) - #776
Merged
climbfuji merged 9 commits intoAug 10, 2026
Conversation
…ween different computers/users
…r to address missing Fortran vs metadata validation checks for 'protected' and other attributes post-capgen-unification
…les passed via argument list, plus tests. Also: tests for issue 772 in capgen v0 (not an issue in v1)
Collaborator
Author
|
@jimmielin FYI |
…otected_attribute_PLUS_issues_772_774
peverwhee
requested changes
Aug 10, 2026
peverwhee
left a comment
Collaborator
There was a problem hiding this comment.
thanks @climbfuji !
a couple requests; and a question
Co-authored-by: Courtney Peverley <courtneyp@ucar.edu>
peverwhee
approved these changes
Aug 10, 2026
Collaborator
Author
|
Same as for #773, merging into |
climbfuji
deleted the
feature/claude_followups_and_protected_attribute_PLUS_issues_772_774
branch
August 10, 2026 21:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note. This PR contains the changes from #773 - it must be updated after #773 is merged into
feature/capgen-v1.type = controlmetadata table, which is only used as as the l.h.s. in the explicit argument lists to the CCPP calls (call ccpp_physics_runetc.) and then passed down to the suite and group caps.User interface changes?: No
Fixes: #774
Testing: all pass
test removed:
unit tests: added tests to cover the situation in #774
system tests:
end-to-end tests: updated advection test to match #771
manual testing: