Skip to content

[feature/capgen-v1]: Test for issue 772 in capgen v0, fix for issue 774 (name collision in capgen v1) - #776

Merged
climbfuji merged 9 commits into
feature/capgen-v1from
feature/claude_followups_and_protected_attribute_PLUS_issues_772_774
Aug 10, 2026
Merged

[feature/capgen-v1]: Test for issue 772 in capgen v0, fix for issue 774 (name collision in capgen v1)#776
climbfuji merged 9 commits into
feature/capgen-v1from
feature/claude_followups_and_protected_attribute_PLUS_issues_772_774

Conversation

@climbfuji

@climbfuji climbfuji commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Description

Note. This PR contains the changes from #773 - it must be updated after #773 is merged into feature/capgen-v1.

  1. Fix for issue v1: two host variables sharing a local name with different standard names will compile but clobber silently #774 - host module import name clash with control variables passed via argument list, plus tests. Instead of implementing some black magic, we simply bail out and instruct the user to fix the name collision. This is easy - simply change the "local name" in the type = control metadata table, which is only used as as the l.h.s. in the explicit argument lists to the CCPP calls (call ccpp_physics_run etc.) and then passed down to the suite and group caps.
  2. Also: tests for issue Local name collisions in generated group caps #772 in capgen v0 (not an issue in v1, but adding the same test to demonstrate).

User interface changes?: No

Fixes: #774

Testing: all pass
test removed:
unit tests: added tests to cover the situation in #774
system tests:
end-to-end tests: updated advection test to match #771
manual testing:

…r to address missing Fortran vs metadata validation checks for 'protected' and other attributes post-capgen-unification
…les passed via argument list, plus tests. Also: tests for issue 772 in capgen v0 (not an issue in v1)
@climbfuji
climbfuji marked this pull request as ready for review August 8, 2026 01:14
@climbfuji
climbfuji requested review from a team as code owners August 8, 2026 01:14
@climbfuji
climbfuji changed the base branch from develop to feature/capgen-v1 August 8, 2026 01:14
@climbfuji climbfuji self-assigned this Aug 8, 2026
@climbfuji
climbfuji requested a review from peverwhee August 8, 2026 01:16
@climbfuji

Copy link
Copy Markdown
Collaborator Author

@jimmielin FYI

@dustinswales dustinswales left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peverwhee peverwhee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @climbfuji !

a couple requests; and a question

Comment thread capgen/generator/group_cap.py
Comment thread capgen/generator/group_cap.py
Comment thread capgen/generator/group_cap.py
climbfuji and others added 2 commits August 10, 2026 14:24
@climbfuji
climbfuji requested a review from peverwhee August 10, 2026 20:43
Comment thread capgen/generator/group_cap.py
@climbfuji

Copy link
Copy Markdown
Collaborator Author

Same as for #773, merging into feature/capgen-v1 with NOAA and NCAR approvals, and because reviewers can look at an earlier commit on the feature/capgen-v1 branch.

@climbfuji
climbfuji merged commit 4005db4 into feature/capgen-v1 Aug 10, 2026
8 checks passed
@climbfuji
climbfuji deleted the feature/claude_followups_and_protected_attribute_PLUS_issues_772_774 branch August 10, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1: two host variables sharing a local name with different standard names will compile but clobber silently

3 participants