Split FPMIX into NL_VSTRESS and LAGRANGIAN_MIXING - #442
Open
alperaltuntas wants to merge 1 commit into
Open
Conversation
Port Bill Large's updates to his nonlocal momentum flux (FPMIX)
parameterization. FPMIX previously did two things at once: add the
nonlocal momentum flux increments in the boundary layer, and make the
implicit vertical viscosity act on the Eulerian shear by removing the
Stokes drift before the solve and restoring it afterward. These are
now controlled independently:
- NL_VSTRESS (replaces FPMIX) controls only the nonlocal stress increments
- LAGRANGIAN_MIXING, previously an unwired placeholder that stopped
the model if enabled, now selects which shear (Lagrangian or Eulerian)
vertical mixing acts on.
Also add KPP_USE_ER so the Entrainment Rule boundary layer depth
search can be disabled independently of STOKES_MOST (default True,
preserving existing behavior)
FPMIX still works during a transition period: an explicitly set FPMIX
provides the defaults for both new parameters (with a deprecation
warning), so existing configurations reproduce their answers without
modification; explicitly set new parameters take precedence.
All answers are bitwise identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port Bill Large's updates to his nonlocal momentum flux (FPMIX) parameterization. FPMIX previously did two things at once: add the nonlocal momentum flux increments in the boundary layer, and make the implicit vertical viscosity act on the Eulerian shear by removing the Stokes drift before the solve and restoring it afterward. These are now controlled independently:
Also add KPP_USE_ER so the Entrainment Rule boundary layer depth search can be disabled independently of STOKES_MOST (default True, preserving existing behavior)
FPMIX still works during a transition period: an explicitly set FPMIX provides the defaults for both new parameters (with a deprecation warning), so existing configurations reproduce their answers without modification; explicitly set new parameters take precedence.
Testing: pr_mom. All answers are bitwise identical.