Skip to content

feat: add MelonLoader version check to prevent crashes (#36) #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siakinnik wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add MelonLoader version check to prevent crashes (#36) #59

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
114374e
feat: add MelonLoader version check (fixes #36)
siakinnik May 10, 2026
220398c
refactor: improve ML version check based on AI review
siakinnik May 10, 2026
62f1c9a
fix: ensure user-facing alert on version check failure and cleanup pr…
siakinnik May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions MaiChartManager/Launcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,38 @@ private void StartClicked(object? sender, EventArgs? e)
return;
}

try
{
string mlDllPath = Path.Combine(StaticSettings.GamePath, "MelonLoader", "MelonLoader.dll");
if (!File.Exists(mlDllPath))
{
mlDllPath = Path.Combine(StaticSettings.GamePath, "..", "MelonLoader", "MelonLoader.dll");
}

if (File.Exists(mlDllPath))
{
var versionInfo = System.Diagnostics.FileVersionInfo.GetVersionInfo(mlDllPath);
string version = versionInfo.ProductVersion ?? "unknown";

if (!version.StartsWith("0.6.4"))
{
// i8n pls
var dialogResult = MessageBox.Show(

@clansty clansty May 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not very important and no need to msgbox on startup. banner in mod setting page is ok

$"Detected MelonLoader version {version}, but 0.6.4 is recommended for stability. Continue anyway?",
"MelonLoader Version Warning",
MessageBoxButtons.YesNo,
MessageBoxIcon.Warning);

if (dialogResult == DialogResult.No) return;
}
}
}
catch (Exception ex)
{
// add i8n, pleeeeease
Console.WriteLine($"Failed to check MelonLoader version: {ex.Message}");
}
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.

if (ContainsSpecialCharacters(StaticSettings.GamePath))
{
MessageBox.Show(Locale.PathContainsSpecialChars, Locale.PathContainsSpecialCharsTitle, MessageBoxButtons.OK, MessageBoxIcon.Warning);
Expand Down