Skip to content

feat: add MelonLoader version check to prevent crashes (#36) #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siakinnik wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add MelonLoader version check to prevent crashes (#36) #59

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
114374e
feat: add MelonLoader version check (fixes #36)
siakinnik May 10, 2026
220398c
refactor: improve ML version check based on AI review
siakinnik May 10, 2026
62f1c9a
fix: ensure user-facing alert on version check failure and cleanup pr…
siakinnik May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions MaiChartManager/Launcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,25 @@ private void StartClicked(object? sender, EventArgs? e)
return;
}

string mlDllPath = Path.Combine(StaticSettings.GamePath, "..", "MelonLoader", "MelonLoader.dll");

@gemini-code-assist gemini-code-assist Bot May 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The path construction for MelonLoader.dll using .. assumes the game files are always in a subfolder (e.g., Package). In a standard installation where Sinmai_Data is in the root folder, StaticSettings.GamePath will be the root, and .. will point to the parent directory of the game, causing the check to fail. Consider checking both the current GamePath and its parent to support both installation layouts.

        string mlDllPath = Path.Combine(StaticSettings.GamePath, "MelonLoader", "MelonLoader.dll");
        if (!File.Exists(mlDllPath))
        {
            mlDllPath = Path.Combine(StaticSettings.GamePath, "..", "MelonLoader", "MelonLoader.dll");
        }

if (File.Exists(mlDllPath))
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
Outdated
{
var versionInfo = System.Diagnostics.FileVersionInfo.GetVersionInfo(mlDllPath);
string? version = versionInfo.ProductVersion;

if (version == null || !version.StartsWith("0.6.4"))
{
var dialougResult = MessageBox.Show(
// Add i8n pls :)
$"Detected MelonLoader version {version}, but 0.6.4 is recommended for stability. Continue anyway?",
"MelonLoader Version Warning",
MessageBoxButtons.YesNo,
MessageBoxIcon.Warning);

if (dialougResult == DialogResult.No) return;
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
Outdated

@gemini-code-assist gemini-code-assist Bot May 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The MessageBox strings are hardcoded in English, and there is a typo in the variable name dialougResult. Since the project supports multiple languages and you've explicitly requested i18n, these strings should be moved to the Locale.resx resource file.

Note: You will need to add the keys MelonLoaderVersionWarning and MelonLoaderVersionWarningTitle to your resource files.

                var dialogResult = MessageBox.Show(
                    string.Format(Locale.MelonLoaderVersionWarning, version ?? "unknown"),
                    Locale.MelonLoaderVersionWarningTitle,
                    MessageBoxButtons.YesNo,
                    MessageBoxIcon.Warning);

                if (dialogResult == DialogResult.No) return;

}
}

if (ContainsSpecialCharacters(StaticSettings.GamePath))
{
MessageBox.Show(Locale.PathContainsSpecialChars, Locale.PathContainsSpecialCharsTitle, MessageBoxButtons.OK, MessageBoxIcon.Warning);
Expand Down