fix(brain-checklist): @mention the CSM on brain submission Slack posts - #145
Open
rezakhadjavi wants to merge 1 commit into
Open
fix(brain-checklist): @mention the CSM on brain submission Slack posts#145rezakhadjavi wants to merge 1 commit into
rezakhadjavi wants to merge 1 commit into
Conversation
Adds BRAIN_CHECKLIST_SLACK_MENTION env. When set, the parent submission message opens with the mention so the owning CSM is actually notified (channel posts alone do not ping anyone).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Brain submission Slack posts go to a single channel (
BRAIN_CHECKLIST_SLACK_CHANNEL, #josh-runneth) but never @mention anyone, so the owning CSM only sees them if channel notifications happen to surface them.Separately, the channel var was missing in prod entirely, so delivery silently no-op'd (handled via Railway config, not this PR).
What
Adds optional
BRAIN_CHECKLIST_SLACK_MENTIONenv. When set (e.g.<@U06NGLVPAQ0>), the parent message opens with that mention so the CSM is actually pinged. Unset = no mention line, no behavior change.The prod env var is already set to Josh's Slack ID; this PR is what makes the code use it.
Reported by Josh.