Repository navigation
Conversation
When the new setting is enabled, a batch queue asks the first trusted APK download helper for every app that has no APK, choosing the newest version its patches support, and moves on to the next app once the file is attached. Helper results still go through the usual package, version and signature checks.
The automatic helper pass now also fetches an APK for a queued app whose saved or installed APK is behind the newest version the patches offer, instead of only for apps with no APK at all. An app already at the newest version, or past it, is left alone, and a version the user turned down on the home screen is not fetched. The recommended version still follows the source order, the prerelease patch setting and the per-source experimental version setting.
Opening a batch queue no longer starts the helper pass. The pass now runs after the user presses Start, fetches the missing and newer APKs, and then starts the queue itself. Cancelling a helper aborts the start and leaves the queue in preflight. The Start button stays available for a queue that only lacks APKs, as long as a trusted helper is there to fetch them.
Author
|
The build failed before the tests started: the Gradle wrapper download of gradle-9.8.2-bin.zip returned HTTP 504 from services.gradle.org. The same commit passes unit tests, lint and assembleRelease in a separate CI run, so a re-run of the workflow should be enough. The new run is waiting for approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Batch patching can now fetch the APKs it needs through a trusted helper on its own. A new switch under Settings > APK download helper, "Download APKs automatically in batch", checks every queued app for the newest APK version its patches support and asks the first trusted helper for it when the app has no APK or is behind that version.
The pass starts only after the user presses Start. It walks the queue one app at a time, attaches each returned APK, and then starts the queue as usual. Cancelling a helper stops the pass and leaves the queue in preflight.
It respects:
It never downgrades an app that is newer than everything the patches support.
Morphe still checks the package, version and signature of every APK the helper returns before patching. The helper contract itself is unchanged.
Testing
:app:testDebugUnitTestand:app:lintpassassembleReleasebuildsCloses #891