Skip to content

[4448] fix: allow style switching back to Beamer without saving. #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adi-coderr wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −2
Open

[4448] fix: allow style switching back to Beamer without saving. #4452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion TeXmacs/progs/generic/document-style.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,13 @@
) ;when
) ;tm-define

(tm-define (beamer-style-switch-allowed?)
(or (document-empty?)
(buffer-modified? (current-buffer))
(has-main-style? "beamer")
) ;or
) ;tm-define

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; High level routines for style and style package management
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
Expand All @@ -140,7 +147,9 @@
(:default style "generic")
(:check-mark "v" has-main-style?)
(:balloon style-get-documentation)
(if (and (== style "beamer") (not (document-empty?)))
(if (and (== style "beamer")
(not (beamer-style-switch-allowed?))
) ;and
(show-message "Switching non-empty documents to Beamer style is not supported"
"Cannot switch style"
) ;show-message
Expand Down
21 changes: 20 additions & 1 deletion TeXmacs/progs/generic/test/generic-test.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,27 @@
(check (focus-tag-name 'big-table) => "big table")
) ;define

(define (beamer-switch-allowed? empty? dirty? already-beamer?)
(or empty? dirty? already-beamer?)
) ;define

(define (test-beamer-switch-allowed?)
;; Empty documents may always switch to Beamer.
(check (beamer-switch-allowed? #t #f #f) => #t)
;; A dirty buffer is allowed to switch back to Beamer without requiring a save.
(check (beamer-switch-allowed? #f #t #f) => #t)
;; A document that is already Beamer should not be blocked.
(check (beamer-switch-allowed? #f #f #t) => #t)
;; A non-empty, clean, non-Beamer document remains blocked.
(check (beamer-switch-allowed? #f #f #f) => #f)
) ;define

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Test entry point
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

(tm-define (regtest-generic) (test-focus-tag-name) (check-report))
(tm-define (regtest-generic)
(test-focus-tag-name)
(test-beamer-switch-allowed?)
(check-report)
) ;tm-define