fix unclosed IO resources, unify notebot folder creation#6435
Open
MukjepScarlet wants to merge 2 commits into
Open
fix unclosed IO resources, unify notebot folder creation#6435MukjepScarlet wants to merge 2 commits into
MukjepScarlet wants to merge 2 commits into
Conversation
crosby-moe
reviewed
May 25, 2026
| final String text = reader.getRemaining(); | ||
| reader.setCursor(reader.getTotalLength()); | ||
| return MeteorClient.FOLDER.toPath().resolve("notebot/" + text); | ||
| return Notebot.PATH.toPath().resolve(text); |
Collaborator
There was a problem hiding this comment.
would be a good idea to throw a CommandSyntaxException on path traversal here
Contributor
Author
There was a problem hiding this comment.
e.g. text contains ..?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
A summary of the changes along with the reasoning behind the changes.
Related issues
Nothing I guess
How Has This Been Tested?
Local env (development)
Checklist: