Skip to content

fix: decodeBool should handle float and string in weakly typed mode #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beck-8 wants to merge 1 commit into
base: Alpha
Choose a base branch
from
Open

fix: decodeBool should handle float and string in weakly typed mode #2809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/structure/structure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,17 @@ func (d *Decoder) decodeBool(name string, data any, val reflect.Value) (err erro
val.SetBool(dataVal.Int() != 0)
case isUint(kind) && d.option.WeaklyTypedInput:
val.SetBool(dataVal.Uint() != 0)
case isFloat(kind) && d.option.WeaklyTypedInput:
val.SetBool(dataVal.Float() != 0)
case kind == reflect.String && d.option.WeaklyTypedInput:
s := dataVal.String()
if b, err2 := strconv.ParseBool(s); err2 == nil {
val.SetBool(b)
} else if f, err2 := strconv.ParseFloat(s, 64); err2 == nil {
val.SetBool(f != 0)
} else {
err = fmt.Errorf("cannot parse '%s' as bool: %s", name, s)
}
default:
err = fmt.Errorf(
"'%s' expected type '%s', got unconvertible type '%s'",
Expand Down
Loading