Skip to content

Use suggested order for BindingSpace trie join#14

Draft
MesTTo wants to merge 1 commit into
pr/mork-expression-trie-reusefrom
pr/mork-binding-suggested-trie-order
Draft

Use suggested order for BindingSpace trie join#14
MesTTo wants to merge 1 commit into
pr/mork-expression-trie-reusefrom
pr/mork-binding-suggested-trie-order

Conversation

@MesTTo

@MesTTo MesTTo commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Uses the analyzed variable order for BindingSpace trie joins.

The branch adds BindingSidecarPlan::execute_trie_join_suggested. It opens the existing plan factors, computes the same root-domain analysis used by analyze, chooses the suggested variable order, and runs the trie-backed join with that order.

The regression compares the suggested-order result with the manual-order trie join and checks that result rows remain equivalent when projected back into the plan's original order.

Validation:

  • cargo +nightly-2026-06-01 test -p mork --lib binding_plan with RUSTFLAGS='-C target-cpu=native'
  • cargo +nightly-2026-06-01 test -p mork --lib with RUSTFLAGS='-C target-cpu=native'
  • rustfmt --check on kernel/src/binding_plan.rs
  • jscpd on kernel/src/binding_plan.rs, kernel/src/expression_trie.rs, kernel/src/pattern_relations.rs, kernel/src/test_exprs.rs, and kernel/src/test_sidecar_queries.rs
  • git diff --check
  • normal diffstat matched git diff -w --stat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant