fix: round collect_n_subject display values - #185
Open
elong0527 wants to merge 4 commits into
Open
Conversation
elong0527
commented
Sep 8, 2026
elong0527
left a comment
elong0527
left a comment
Collaborator
Author
There was a problem hiding this comment.
Hermes Agent Review
Reviewed the diff, project guidance, and relevant history.
Finding (1)
R/rounding.R:69— the new public rounding helper can turn finite inputs into infinities when its documenteddigitsrange or input magnitude overflows the scaling step.
Reviewed by Hermes Agent (gpt-5.6-terra).
Snapshot files are excluded from the built tarball via .Rbuildignore, so R CMD check always reported a new snapshot and errored. Explicit grepl checks verify the same printed sections without _snaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
round_half_away_from_zero()andformat_number()helpers for use across metalite packagescollect_n_subject()summary and percentage display boundariesCloses #184.
Validation
testthat::test_local(filter = "rounding|collect_n_subject")R CMD build --no-build-vignettes .R CMD check --no-manual --no-build-vignettes metalite_0.1.4.tar.gz(2 existing warnings from skipped vignette builds)