sysinfo-snapshot: fix ethtool -S links in generated HTML - #39
Open
dthompso wants to merge 1 commit into
Open
Conversation
dthompso
force-pushed
the
dthompso-fix_ethtool_S
branch
2 times, most recently
from
June 5, 2026 14:45
8feb235 to
f786a99
Compare
ethtool_all_interfaces is rendered from network_commands_dict, so the link-preserving path in html_write_paragraph never ran and anchor tags were escaped as literal text. Handle ethtool_all_interfaces and devlink_handler before the available_commands_collection check, and detect link lines with a generic '<a href' match. Build ethtool -S artifact paths with a shared relative path, quoted href attributes, and safer interface-name sanitization so links target the files written under ethtool_S/. Signed-off-by: David Thompson <davthompson@nvidia.com>
dthompso
force-pushed
the
dthompso-fix_ethtool_S
branch
from
June 5, 2026 15:24
f786a99 to
73183ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ethtool_all_interfaces is rendered from network_commands_dict, so the link-preserving path in html_write_paragraph never ran and anchor tags were escaped as literal text. Handle ethtool_all_interfaces and devlink_handler before the available_commands_collection check, and detect link lines with a generic '<a href' match.
Build ethtool -S artifact paths with a shared relative path, quoted href attributes, and safer interface-name sanitization so links target the files written under ethtool_S/.
Before this fix the "ethtool -S" portion of the generated HTML looked like:
ethtool -S output:
ethtool -S ib0
ethtool -S ib0ethtool -S lo
ethtool -S loethtool -S oob_net0
ethtool -S oob_net0ethtool -S tmfifo_net0
ethtool -S tmfifo_net0Now, the "ethtool -S" portion looks like (each command is underlined hyperlink):
ethtool -S output:
ethtool -S ib0
ethtool -S lo
ethtool -S oob_net0
ethtool -S tmfifo_net0