fix: Add accessible name to emojis - EXO-87562 - #5897
Open
akhanfir wants to merge 10 commits into
Open
Conversation
ahamdi
requested changes
Jul 20, 2026
ahamdi
left a comment
ahamdi
left a comment
Member
There was a problem hiding this comment.
This file is for purifying the content, the emoji names handling should not go here
exo-swf
force-pushed
the
feature/maintenance
branch
from
July 20, 2026 23:18
142f5bd to
19924d1
Compare
akhanfir
force-pushed
the
TASK-87562
branch
2 times, most recently
from
July 21, 2026 09:27
1de44e0 to
e413a44
Compare
exo-swf
force-pushed
the
feature/maintenance
branch
2 times, most recently
from
July 22, 2026 23:18
27ac8ff to
cb9b1a9
Compare
akhanfir
force-pushed
the
TASK-87562
branch
2 times, most recently
from
July 23, 2026 16:26
e5541eb to
ada43a7
Compare
…n - EXO-88253 (#5887) The two focusable elements (card + name) are Vuetify v-cards rather than divs, to benefit from the outline: none already integrated into the .v-card class (avoids the browser's default focus outline which was hiding our custom border) — without adding any CSS/style specific to this component.
Before this change, when accessing the space directory and clicking the filter button, the filter field had no aria-label/title, making it inaccessible to screen readers. To fix this problem, add aria-label/title=`Filter by name or description to the filter field` and update its placeholder to `Search for a space`. After this change, the filter field is properly labeled for accessibility
Before this change, when accessing the user directory and clicking the filter button, the filter field had no aria-label/title, making it inaccessible to screen readers. To fix this problem, add aria-label/title=`Filter by name to the filter field` and update its placeholder to `Search for a user`. After this change, the filter field is properly labeled for accessibility.
Before this change, when access to note application and click on the fiter button, the filter field hasn't a label. After this change, add aria-label/title=`Search for content to the search field` and update its placeholder to `Start searching content...`, and add aria-label/title=`Filter by tag name to the tag filter field`.
Before this change, when userA make spaceX notes page as him own home page and USerA user an url that generates page-not-found then userA clicks on Back Home button, /dw page is displayed. To fix this problem, change the default link to home link in the PageNotFound. After this change, the home page is displayed.
…5908) Before this change, when sending a URL in chat or tasks and the link is displayed correctly, then clicking on the link, the URL opened is one that doesn't exist and a 404 page is displayed. To fix this problem, the encodeURI call is removed; the raw URL, already correctly encoded as returned by match.getUrl(), is used, consistent with Utils.js:toLinkUrl, which already works without this additional encoding. After this change, the link opens the correct URL.
exo-swf
force-pushed
the
feature/maintenance
branch
from
July 23, 2026 23:18
f8c4035 to
858273a
Compare
Before this change, the filter field showed a custom Vuetify tooltip in addition to the native title attribute already added for accessibility. To fix this, the custom tooltip has been removed from the shared toolbar component, along with its now-unused configuration. After this change, the filter field relies solely on the native tooltip.
Before this change, when userA make spaceX notes page as him own home page and USerA user an url that generates page-not-found then userA clicks on Back Home button, /dw page is displayed. To fix this problem, change the default link to home link in the PageNotFound. After this change, the home page is displayed.
|
exo-swf
force-pushed
the
feature/maintenance
branch
3 times, most recently
from
July 26, 2026 23:18
699f324 to
99012c9
Compare
exo-swf
force-pushed
the
feature/maintenance
branch
2 times, most recently
from
July 29, 2026 23:18
9f5bf25 to
0f6cd16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered emojis had no accessible name, making them invisible to screen readers.