fix: normalize space id in SpaceCategoryPlugin so category links apply to spaces - EXO-88506 - #5895
Open
bmestrallet wants to merge 3 commits into
Open
Conversation
The Theme management page's default page background color (used both as the picker's placeholder and normalized when reading an already persisted 6-digit value) had no alpha channel, so the color picker silently dropped its transparency slider. Also stop the gradient from/to parser from garbling non-linear-gradient values (e.g. conic gradients set elsewhere) instead of falling back to solid color.
…y to spaces - EXO-88506 Category links are generic metadata keyed on (objectType, objectId), but the space UI/REST reads a denormalized space.getCategoryIds() kept in sync only by CategoryLinkModifiedListener, whose SPACE branch resolves the space via spaceService.getSpaceById(object.getId()) and therefore requires the space technical id. SpaceCategoryPlugin did not override getObject(), so when a caller (e.g. the MCP tooling) passed the space identity id or its pretty name, the raw link was written/read-back under that id (false success) while the listener resolved the wrong space or null, leaving space.categoryIds untouched and the UI empty. Override CategoryPlugin.getObject() to normalize any incoming space id form (technical id, social Identity id or pretty name) to the canonical technical id String.valueOf(space.getSpaceId()). Since link()/getLinkedIds() and the listener all funnel through getObject(), the write, the read-back and the denormalization now agree regardless of which id was supplied. Unresolvable ids are returned unchanged rather than silently corrupted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Jihed525
added a commit
that referenced
this pull request
Jul 20, 2026
…y to spaces - EXO-88506 Backport of #5895 onto develop. Overrides CategoryPlugin.getObject() in SpaceCategoryPlugin to normalize the technical id / identity id / pretty name to the canonical String.valueOf(space.getSpaceId()), so space category links written via non-technical ids (e.g. MCP calls) are correctly reflected in space.getCategoryIds(). Unresolvable ids are returned unchanged rather than silently corrupted. Note: source PR #5895 is still open upstream (not yet merged into feature/ai-contribution); this backport is being pushed to develop at the requester's explicit direction, in parallel with mcp-server #16 and content #838, which all address the same category-MCP-tools ticket (EXO-88506). Backport notes Cherry-picked commit 70db850 cleanly onto develop, no conflicts. Test mvn -pl component/core -am -Dcheckstyle.skip=true -DskipTests install → BUILD SUCCESS mvn -pl component/core -Dcheckstyle.skip=true -Dtest=SpaceCategoryPluginUnitTest,CategoryLinkServiceTest test → 8 tests, 0 failures/errors 🤖 Generated with Claude Code
exo-swf
force-pushed
the
feature/ai-contribution
branch
7 times, most recently
from
July 27, 2026 01:39
66cf47b to
102b2fa
Compare
exo-swf
force-pushed
the
feature/ai-contribution
branch
from
July 28, 2026 11:13
102b2fa to
ce9ed1d
Compare
bmestrallet
force-pushed
the
feature/ai-contribution
branch
from
July 28, 2026 12:18
ce9ed1d to
d7293f4
Compare
exo-swf
force-pushed
the
feature/ai-contribution
branch
from
July 28, 2026 13:08
d7293f4 to
266691b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the space half of EXO-88506: MCP category linking (and any caller passing a non-technical space id) succeeded and read back as linked, but the space UI/REST never reflected it.
Root cause
Category links are generic
(objectType, objectId)metadata, but the space UI/REST read a denormalizedspace.getCategoryIds()kept in sync only byCategoryLinkModifiedListener, whose SPACE branch doesspaceService.getSpaceById(Long.parseLong(object.getId()))— i.e. it requires the space technical id.SpaceCategoryPluginnever overrodegetObject(), so when a caller passed the space identity id (how spaces are referenced across the platform) or a pretty name, the raw link was written + read back under that id (false success), but the listener resolved the wrong space/null and never updatedcategoryIds. Activities worked because they have a single id.Fix
Override
CategoryPlugin.getObject(...)inSpaceCategoryPluginto normalize any incoming id form (technical id / identity id / pretty name) to the canonical technical idString.valueOf(space.getSpaceId()). Becauselink()/unlink()/getLinkedIds()and the listener all funnel throughgetObject(), the write, read-back and denormalization now agree regardless of which id was passed. Resolution triesgetSpaceByIdfirst (so a valid technical id is never re-interpreted), then identity-id viaIdentityManager, then pretty name; unresolvable ids pass through unchanged.Tests + live verification
SpaceCategoryPluginUnitTest(technical/identity/pretty-name all normalize) + a newCategoryLinkServiceTestcase linking a space by identity id and assertingspace.getCategoryIds()reflects it (fails without this fix). Both green.🤖 Generated with Claude Code