[catalog] split builtin.rs into per-schema submodule files#36478
Merged
mtabebe merged 1 commit intoMaterializeInc:mainfrom May 8, 2026
Merged
[catalog] split builtin.rs into per-schema submodule files#36478mtabebe merged 1 commit intoMaterializeInc:mainfrom
mtabebe merged 1 commit intoMaterializeInc:mainfrom
Conversation
builtin.rs had grown to 18k lines, making it difficult to navigate. (MaterializeInc#36406 (comment)) Split the builtin item definitions into five submodule files under src/catalog/src/builtin/, organized by schema: - pg_catalog.rs TYPE_* consts + pg_catalog views - mz_catalog.rs mz_catalog tables/views/sources - mz_internal.rs mz_internal views/tables/sources/indexes - mz_introspection.rs mz_introspection logs/views - information_schema.rs information_schema views builtin.rs now holds: type/trait/struct definitions, shared helper consts, roles/clusters, BUILTINS_STATIC, the BUILTINS pub mod, and lookup tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builtin.rs had grown to 18k lines, making it difficult to navigate. (#36406 (comment))
Split the builtin item definitions into five submodule files under src/catalog/src/builtin/, organized by schema:
builtin.rs now holds: type/trait/struct definitions, shared helper consts, roles/clusters, BUILTINS_STATIC, the BUILTINS pub mod, and lookup tables.