fix(init): correct resolution tuple ordering in CFG_DEFAULTS#4839
Open
aoxiangtianyu-go wants to merge 1 commit into
Open
fix(init): correct resolution tuple ordering in CFG_DEFAULTS#4839aoxiangtianyu-go wants to merge 1 commit into
aoxiangtianyu-go wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR fixes a resolution inconsistency between the
--defaultproject initialization path and the interactive resolution selection flow.The current
CFG_DEFAULTSdefines:which is interpreted as
(pixel_height, pixel_width)in the configuration system, resulting in an inverted default resolution compared to the interactive1080pselection path andQUALITIESdefinitions.It is updated to:
to align the
--defaultinitialization behavior with the rest of the CLI resolution pipeline.Motivation and Explanation: Why and how do your changes improve the library?
There is an inconsistency in how resolution tuples are represented during initialization:
select_resolution()returns(pixel_height, pixel_width)QUALITIESdefines resolution explicitly usingpixel_heightandpixel_widthupdate_cfg()interprets resolution tuples as(height, width)However,
CFG_DEFAULTSpreviously defined resolution as(1920, 1080), which is inconsistent with this convention and leads to inverted default behavior when usingmanim init --default.This reduces ambiguity and prevents unexpected inversion of width/height when using default project initialization.
Links to added or changed documentation pages
No documentation changes are required for this fix.
Further Information and Comments
There are broader architectural inconsistencies in how resolution is represented across the initialization pipeline (tuple-based vs explicit
pixel_height/pixel_widthfields).This change is intentionally minimal and scoped only to correcting the default initialization value.