Fix triangulation ring off-by-one error#4819
Open
Theelx wants to merge 1 commit into
Open
Conversation
ed7e082 to
dd115d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
These changes fix a bug that I encountered with OpenGL rendering for certain scenes. However, the bug did cause rendering to error when its conditions were met, so I figured it should be fixed upstream instead of in a local fork.
Links to added or changed documentation pages
I'm not sure if there are any documentation pages that need to be changed, but I'm open to being corrected!
Further Information and Comments
While the diff for utils/space_ops.py shows 6 lines added, the only real change was changing the bit saying
j < ring[-1]toj <= ring[-1]. The rest of the changes in that file are a comment plus formatting.Reviewer Checklist