Adding llcreader ASTE model on TACC featuring snapshots - #358
Adding llcreader ASTE model on TACC featuring snapshots#358mgoldberg10 wants to merge 10 commits into
Conversation
… lines within llcreader that were broken likely due to some updates to zarr Added unit tests for CRIOSTACCPortalASTE270Model
|
@mjlosch , this PR needs approval from a maintainer (you) to check CI via GitHub. @mgoldberg10 , were you able to produce passing tests for the new ASTE access via |
Yes I got the |
|
@mgoldberg10 Do you think this is ready to be merged? |
@mjlosch I encountered some github CI failures along the way but believe I have them resolved. One of them is independent of my additions on this branch, so I am going to make a separate pull request. Once that is merged, I will circle back on this PR. |
@antnguyen13 copied ASTE Release 1 output to TACC's Corral and included snapshot diagnostics for users interested in budget closures. This PR makes that model available through llcreader. I copied the structure of #231's
CRIOSPortalASTE270Modelhosted on AWS.I added the snapshot diagnostic names to
package_state_variablesbut am open to moving it to its own dictionary.I found I had to update two lines in llcmodel as well in order to access the existing llcreader ASTE models.
Added some unit tests, updated docs.