Skip to content

Adding llcreader ASTE model on TACC featuring snapshots - #358

Closed
mgoldberg10 wants to merge 10 commits into
MITgcm:masterfrom
mgoldberg10:aste-tacc
Closed

Adding llcreader ASTE model on TACC featuring snapshots#358
mgoldberg10 wants to merge 10 commits into
MITgcm:masterfrom
mgoldberg10:aste-tacc

Conversation

@mgoldberg10

Copy link
Copy Markdown
Contributor

@antnguyen13 copied ASTE Release 1 output to TACC's Corral and included snapshot diagnostics for users interested in budget closures. This PR makes that model available through llcreader. I copied the structure of #231's CRIOSPortalASTE270Model hosted on AWS.

I added the snapshot diagnostic names to package_state_variables but am open to moving it to its own dictionary.

I found I had to update two lines in llcmodel as well in order to access the existing llcreader ASTE models.

Added some unit tests, updated docs.

… lines within llcreader that were broken likely due to some updates to zarr

Added unit tests for CRIOSTACCPortalASTE270Model
@IvanaEscobar

Copy link
Copy Markdown
Collaborator

@mjlosch , this PR needs approval from a maintainer (you) to check CI via GitHub.

@mgoldberg10 , were you able to produce passing tests for the new ASTE access via test_llcreader on your local machine?

@mgoldberg10

Copy link
Copy Markdown
Contributor Author

@mjlosch , this PR needs approval from a maintainer (you) to check CI via GitHub.

@mgoldberg10 , were you able to produce passing tests for the new ASTE access via test_llcreader on your local machine?

Yes I got the test_llcreader tests to pass on my machine.

@mgoldberg10
mgoldberg10 marked this pull request as draft March 12, 2026 15:36
@mjlosch
mjlosch marked this pull request as ready for review April 16, 2026 14:49
@mjlosch

mjlosch commented Apr 16, 2026

Copy link
Copy Markdown
Member

@mgoldberg10 Do you think this is ready to be merged?

@IvanaEscobar IvanaEscobar mentioned this pull request Apr 17, 2026
3 tasks
@mgoldberg10

Copy link
Copy Markdown
Contributor Author

@mgoldberg10 Do you think this is ready to be merged?

@mjlosch I encountered some github CI failures along the way but believe I have them resolved. One of them is independent of my additions on this branch, so I am going to make a separate pull request. Once that is merged, I will circle back on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants