-
Notifications
You must be signed in to change notification settings - Fork 833
Add benchmarks for MDAnalysis.analysis.align #5298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
noir4201
wants to merge
2
commits into
MDAnalysis:develop
Choose a base branch
from
noir4201:bench-contacts
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| # bench_align.py | ||
| # Benchmarks for MDAnalysis.analysis.align | ||
| # No benchmarks existed for this module before this file | ||
|
|
||
| import MDAnalysis as mda | ||
| from MDAnalysis.analysis import align | ||
| from MDAnalysis.tests.datafiles import PSF, DCD, PDB_small | ||
|
|
||
|
|
||
| class AlignBenchmark: | ||
| """ | ||
| Benchmarks for MDAnalysis.analysis.align module. | ||
| Tests alignto() and AlignTraj() which are the two | ||
| most commonly used functions in this module. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How were they determined to be the "most commonly used?" Not sure this content is needed in any case. |
||
| """ | ||
|
|
||
| def setup(self): | ||
| # setup() runs ONCE before any timing starts | ||
| # load data here — never in time_ methods | ||
| # PSF = protein structure file (topology) | ||
| # DCD = trajectory file (coordinates over time) | ||
| # PDB_small = single reference structure | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. kind of verbose/not needed I think |
||
| self.mobile = mda.Universe(PSF, DCD) | ||
| self.reference = mda.Universe(PSF, PDB_small) | ||
|
|
||
| def time_alignto_all_atoms(self): | ||
| """Time aligning all atoms of a single frame""" | ||
| align.alignto( | ||
| self.mobile, | ||
| self.reference, | ||
| select="all" | ||
| ) | ||
|
|
||
| def time_alignto_backbone(self): | ||
| """Time aligning backbone atoms only (common in research)""" | ||
| align.alignto( | ||
| self.mobile, | ||
| self.reference, | ||
| select="backbone" | ||
| ) | ||
|
|
||
| def time_alignto_mass_weighted(self): | ||
| """Time aligning with mass weighting""" | ||
| align.alignto( | ||
| self.mobile, | ||
| self.reference, | ||
| select="backbone", | ||
| weights="mass" | ||
| ) | ||
|
|
||
| def time_aligntraj_all_frames(self): | ||
| """Time aligning entire trajectory — most expensive operation""" | ||
| alignment = align.AlignTraj( | ||
| self.mobile, | ||
| self.reference, | ||
| select="backbone", | ||
| in_memory=True # avoids writing to disk during benchmark | ||
| ) | ||
| alignment.run() | ||
|
|
||
| def time_average_structure(self): | ||
| """Time computing average structure across trajectory""" | ||
| avg = align.AverageStructure( | ||
| self.mobile, | ||
| self.reference, | ||
| select="backbone" | ||
| ) | ||
| avg.run() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any of the comments above are needed/useful.