fix: invalid documentation of parameters of smtc_modem_hal_irq_config_radio_irq - #164
Open
rgnter wants to merge 2 commits into
Open
fix: invalid documentation of parameters of smtc_modem_hal_irq_config_radio_irq#164rgnter wants to merge 2 commits into
smtc_modem_hal_irq_config_radio_irq#164rgnter wants to merge 2 commits into
Conversation
…g_radio_irq` Amended the documentation in PORTING_GUIDE.md and fixed the comments in the header.
Remark mentioned a parameter which does not exist anymore. `xosc_cfg` should be set to `RAL_XOSC_CFG_XTAL` if no TXCO is available on the board.
Author
|
I noticed another inconsitency, this time in a remark documentation of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, while implementing the modem for my own firmware I've noticed parameter description inconsistency and broken documentation for functions in
smtc_modem_hal.h.