Fall back to function.name if displayName is not defined#47
Open
soup-in-boots wants to merge 4 commits into
Open
Fall back to function.name if displayName is not defined#47soup-in-boots wants to merge 4 commits into
soup-in-boots wants to merge 4 commits into
Conversation
| NoClickHandler.displayName = 'NoClickHandler'; | ||
|
|
||
| describe('logrocket-react', () => { | ||
| function FunctionComponentWithoutDisplayName(props) { |
There was a problem hiding this comment.
nit: Would it be possible to create some format of factory function to create these function components to reduce duplication?
Author
There was a problem hiding this comment.
Yeah, definitely possible. I'll see what I can whip up!
Author
|
Consolidated the function component definitions with a simple factory. I noticed I could consolidate the class components as well, so I did. I considered the nested series of components, but they're simple and varied enough that I didn't feel I could make them much more concise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fall back to function name if displayName is not defined on a function-type component. Helps with development environments, but is still susceptible to minification or obfuscation mangling the name of the component.