Repository navigation
Validate columnizer type names before loading or creating them - #745
Merged
Merged
Conversation
The assembly resolve handler now only accepts plain assembly names, so a type name read from a settings or .lxp file can no longer point it at a DLL outside the application and plugin directories. ColumnizerJsonConverter only creates instances of concrete ILogLineMemoryColumnizer types; any other type name is treated like an unknown type.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+44
to
+47
| catch | ||
| { | ||
| // The DLL stays locked if a regression loaded it; the assertion already reported that. | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Columnizers stored in settings and
.lxpfiles are restored by assembly-qualified type name. Two places trusted that name more than they should:PluginRegistry.ColumnizerResolveEventHandlerturned the requested assembly name straight into a file path under the application directory. It now accepts only plain assembly names: no path separators, no.., no drive or other invalid file-name characters. Plugin and application assemblies resolve exactly as before.ColumnizerJsonConverter.ReadJsoncalledActivator.CreateInstanceon whateverType.GetTypereturned. Now, a type that isn't a concreteILogLineMemoryColumnizerfalls through to the existing lookups, which only accept columnizers. It then fails with the sameJsonSerializationExceptionas an unknown type, without creating anything.Tests
AssemblyResolverTests(new):null.ColumnizerJsonConverterTests: a non-columnizer type name throws and its constructor never runs.