Skip to content

feat(macos): experimental ProRes VideoToolbox encoder (opt-in, additive protocol) #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nottlespike wants to merge 12 commits into
base: master
Choose a base branch
from

review: trim duplicate SUNSHINE_FORMAT_* static_asserts from test_video

3e3cf99
Select commit
Loading
Failed to load commit list.
Open

feat(macos): experimental ProRes VideoToolbox encoder (opt-in, additive protocol) #5202

review: trim duplicate SUNSHINE_FORMAT_* static_asserts from test_video
3e3cf99
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 27, 2026 in 9m 25s

Quality Gate failed

Failed conditions
7 New issues
7 New Code Smells (required ≤ 0)
1 Duplicated Blocks on New Code (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 64 in src/platform/macos/nv12_zero_device.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce verbosity with "using enum" for "platf::pix_fmt_e". 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5obtqHS-oXNeKBksOs&open=AZ5obtqHS-oXNeKBksOs&pullRequest=5202

Check warning on line 460 in src/nvenc/nvenc_base.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested conditional operator into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5obttWS-oXNeKBksOt&open=AZ5obttWS-oXNeKBksOt&pullRequest=5202

Check failure on line 371 in src/video.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5obtuVS-oXNeKBksOv&open=AZ5obtuVS-oXNeKBksOv&pullRequest=5202

Check warning on line 34 in src/config.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5obtt0S-oXNeKBksOu&open=AZ5obtt0S-oXNeKBksOu&pullRequest=5202

Check failure on line 1241 in src/video.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5obtm0S-oXNeKBksOq&open=AZ5obtm0S-oXNeKBksOq&pullRequest=5202

Check failure on line 1243 in src/video.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5obtm0S-oXNeKBksOr&open=AZ5obtm0S-oXNeKBksOr&pullRequest=5202

Check failure on line 373 in src/video.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5obtuVS-oXNeKBksOw&open=AZ5obtuVS-oXNeKBksOw&pullRequest=5202
View more details on SonarQubeCloud