Skip to content

feat(video): add support for legacy MPEG-2 and H.263+ encoders #5194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ReenigneArcher wants to merge 1 commit into
base: master
Choose a base branch
from

feat(video): add support for legacy MPEG-2 and H.263+ encoders

9f4419d
Select commit
Loading
Failed to load commit list.
Draft

feat(video): add support for legacy MPEG-2 and H.263+ encoders #5194

feat(video): add support for legacy MPEG-2 and H.263+ encoders
9f4419d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 25, 2026 in 9m 32s

Quality Gate failed

Failed conditions
15 New issues
15 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 1255 in src/video.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global pointers should be const at every level. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTgCOcYDVOXjq4Xr&open=AZ5gBTgCOcYDVOXjq4Xr&pullRequest=5194

Check failure on line 363 in src/video.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTnROcYDVOXjq4Xz&open=AZ5gBTnROcYDVOXjq4Xz&pullRequest=5194

Check warning on line 13 in tests/unit/test_video.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "av1_mode". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTo6OcYDVOXjq4X3&open=AZ5gBTo6OcYDVOXjq4X3&pullRequest=5194

Check warning on line 24 in src/video.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "enum" with "enum class". 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTnROcYDVOXjq4Xv&open=AZ5gBTnROcYDVOXjq4Xv&pullRequest=5194

Check failure on line 1258 in src/video.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTgCOcYDVOXjq4Xs&open=AZ5gBTgCOcYDVOXjq4Xs&pullRequest=5194

Check failure on line 10 in tests/unit/test_video.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Customize this struct's copy constructor to participate in resource management. Customize or delete its copy assignment operator. Also consider whether move operations should be customized. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTo6OcYDVOXjq4X5&open=AZ5gBTo6OcYDVOXjq4X5&pullRequest=5194

Check failure on line 688 in src/nvhttp.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 26 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTntOcYDVOXjq4X0&open=AZ5gBTntOcYDVOXjq4X0&pullRequest=5194

Check warning on line 2851 in src/video.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 23 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTgCOcYDVOXjq4Xu&open=AZ5gBTgCOcYDVOXjq4Xu&pullRequest=5194

Check warning on line 14 in tests/unit/test_video.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "mpeg2_mode". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTo6OcYDVOXjq4X1&open=AZ5gBTo6OcYDVOXjq4X1&pullRequest=5194

Check failure on line 361 in src/video.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTnROcYDVOXjq4Xx&open=AZ5gBTnROcYDVOXjq4Xx&pullRequest=5194

Check warning on line 15 in tests/unit/test_video.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "h263p_mode". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTo6OcYDVOXjq4X2&open=AZ5gBTo6OcYDVOXjq4X2&pullRequest=5194

Check warning on line 12 in tests/unit/test_video.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "hevc_mode". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTo6OcYDVOXjq4X4&open=AZ5gBTo6OcYDVOXjq4X4&pullRequest=5194

Check failure on line 1259 in src/video.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTgCOcYDVOXjq4Xt&open=AZ5gBTgCOcYDVOXjq4Xt&pullRequest=5194

Check failure on line 360 in src/video.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTnROcYDVOXjq4Xw&open=AZ5gBTnROcYDVOXjq4Xw&pullRequest=5194

Check failure on line 362 in src/video.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTnROcYDVOXjq4Xy&open=AZ5gBTnROcYDVOXjq4Xy&pullRequest=5194
View more details on SonarQubeCloud