Skip to content

fix(linux/vulkan): harden encoder fallback #5174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeafridi wants to merge 1 commit into
base: master
Choose a base branch
from
+153 −31

harden vulkan encoder fallback and KMS monitor failure handling

b6c8fec
Select commit
Loading
Failed to load commit list.
Open

fix(linux/vulkan): harden encoder fallback #5174

harden vulkan encoder fallback and KMS monitor failure handling
b6c8fec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 27, 2026 in 0s

17.74% (-0.05%) compared to 3c7952b

View this Pull Request on Codecov

17.74% (-0.05%) compared to 3c7952b

Details

Codecov Report

❌ Patch coverage is 11.00000% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.74%. Comparing base (3c7952b) to head (b6c8fec).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/vulkan_encode.cpp 0.00% 43 Missing ⚠️
src/video.cpp 13.63% 20 Missing and 18 partials ⚠️
src/platform/linux/kmsgrab.cpp 38.46% 4 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5174      +/-   ##
==========================================
- Coverage   17.78%   17.74%   -0.05%     
==========================================
  Files         111      111              
  Lines       24154    24226      +72     
  Branches    10688    10732      +44     
==========================================
+ Hits         4296     4299       +3     
- Misses      14682    15549     +867     
+ Partials     5176     4378     -798
Files with missing lines Coverage Δ
src/platform/linux/kmsgrab.cpp 3.69% <38.46%> (-0.15%) ⬇️
src/video.cpp 31.96% <13.63%> (-0.47%) ⬇️
src/platform/linux/vulkan_encode.cpp 0.30% <0.00%> (-0.03%) ⬇️

... and 31 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7952b...b6c8fec. Read the comment docs.

View more details on Codecov