fix(amf): enable H.264 profile and coder selection

[k4idyn]

Description

• Currently, the AMD AMF encoder (h264_amf) in src/video.cpp does not have the profile and coder options wired up in its encoder_t definition. This prevents clients that strictly require H.264 Baseline/CAVLC (like the Sony PSP or other legacy hardware decoders) from successfully streaming, as the encoder defaults to High Profile and CABAC regardless of the client's request or the global configuration.
• Why this is needed
  Older hardware decoders often have hardwired limitations. For example, the PSP-1000's Media Engine only supports:
• H.264 Baseline Profile (not Main or High)
• CAVLC entropy coding (not CABAC)

While Sunshine/Apollo allows selecting cavlc in the UI, this setting is ignored by the h264_amf encoder because it isn't passed to the FFmpeg avcodec_open2 dictionary.

• Proposed Fix
  Update the amdvce definition in src/video.cpp to include the missing options:

        {"coder"s, &config::video.amd.amd_coder},
        {"profile"s, [](const config_t &cfg) {
           if (cfg.profile == 66) return "baseline"s;
           if (cfg.profile == 77) return "main"s;
           return "high"s;
         }},

This brings the AMD implementation into parity with NVENC and QuickSync.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[ReenigneArcher]

Thank you for the PR submission, but I noticed you didn't use our PR template.

Please update the PR to use the correct template. You can find it at https://github.com/LizardByte/.github/blob/master/.github/pull_request_template.md?plain=1

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ReenigneArcher]

Where is cfg.profile coming from? This pattern doesn't seem to exist anywhere in the codebase.

[ReenigneArcher]

Ref: https://github.com/GPUOpen-LibrariesAndSDKs/AMF/wiki/AMF%20Encoder%20Settings%20and%20Tuning%20in%20FFmpeg#2-amf-encoder-parameter-listings

[k4idyn]

Updated this PR on top of current master and addressed the review feedback about \cfg.profile.

Changes in this update:

• Added missing \coder\ wiring for \h264_amf.
• Replaced the invalid \cfg.profile\ usage with AMF-valid profile mapping based on existing \amd_coder\ config:
  • \cavlc\ -> \constrained_baseline\
  • \cabac\ -> \high\
  • \auto\ -> \main\

Reference used: AMF encoder parameter listings for FFmpeg.

[sonarqubecloud]

Quality Gate failed

Failed conditions
2 New issues
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE