Skip to content

chore(data): add return type annotations to FLAN dataloader methods #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Koushik-Salammagari wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(data): add return type annotations to FLAN dataloader methods #2240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions litgpt/data/flan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class FLAN(DataModule):
train_dataset: SFTDataset | None = field(default=None, init=False, repr=False)
test_dataset: SFTDataset | None = field(default=None, init=False, repr=False)

def __post_init__(self):
def __post_init__(self) -> None:
super().__init__()
if isinstance(self.prompt_style, str):
self.prompt_style = PromptStyle.from_name(self.prompt_style)
Expand Down Expand Up @@ -73,10 +73,10 @@ def prepare_data(self) -> None:
data_file_url = f"{self.url}/{split}/{subset}_{split}.jsonl"
download_if_missing(data_file_path, data_file_url)

def train_dataloader(self):
def train_dataloader(self) -> DataLoader:
return self._dataloader("train")

def val_dataloader(self):
def val_dataloader(self) -> DataLoader:
return self._dataloader("test")

def _dataloader(self, split: str) -> DataLoader:
Expand Down
Loading