fix(server): print localhost Swagger URL instead of 0.0.0.0#714
Open
sarvesh1327 wants to merge 1 commit into
Open
fix(server): print localhost Swagger URL instead of 0.0.0.0#714sarvesh1327 wants to merge 1 commit into
sarvesh1327 wants to merge 1 commit into
Conversation
0.0.0.0 does not work on Windows for local browser access. Use localhost so the printed URL is clickable on all platforms. Fixes Lightning-AI#697
sarvesh1327
requested review from
Abdul-0x4A,
andyland,
aniketmaurya,
dmitsf,
ethanwharris,
justusschock,
k223kim and
tchaton
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http://0.0.0.0:{port}/docstohttp://localhost:{port}/docs.0.0.0.0is not a valid address to open in a browser on Windows, so users copying the URL could not access the docs.localhostworks on Windows, macOS, and Linux.Test Plan
test_disable_openapi_url_print_messageassertion to expectlocalhost.Notes