fix: gracefully stop uvicorn threads during shutdown#687
Open
mkg0908 wants to merge 1 commit into
Open
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
===================================
- Coverage 85% 85% -0%
===================================
Files 39 39
Lines 3282 3289 +7
===================================
+ Hits 2778 2782 +4
- Misses 504 507 +3 🚀 New features to boost your workflow:
|
bhimrazy
reviewed
Jun 3, 2026
Comment on lines
1583
to
+1586
| w = threading.Thread( | ||
| target=server.run, args=(response_queue_id, sockets), name=f"LitServer-{response_queue_id}" | ||
| ) | ||
| setattr(w, "_litserve_server", server) |
Collaborator
There was a problem hiding this comment.
The setattr/getattr approach works but I think a small subclass makes the intent clearer and the handle typed:
class _UvicornServerThread(threading.Thread):
def __init__(self, server: _Server, *args, **kwargs):
super().__init__(*args, **kwargs)
self.server = serverw = _UvicornServerThread(
server, target=server.run, args=(response_queue_id, sockets), name=f"LitServer-{response_queue_id}"
)wdyt ?
cc: @andyland
|
Unfortunately this PR doesn't fix the issue. I just tried it and it was hanging, I got this output. and it never finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.should_exitinstead of calling process-onlyterminate()andkill()methodsTests
.venv/bin/python -m ruff check src/litserve/server.py tests/unit/test_lit_server.py.venv/bin/python -m compileall -q src/litserve/server.py tests/unit/test_lit_server.pyCloses #684