fix(rerun): turn off reruns for ui target - #1038
Conversation
Signed-off-by: Silvia Tarabova <starabov@redhat.com>
📝 WalkthroughWalkthroughThe ChangesUI test rerun control
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@testsuite/tests/singlecluster/ui/console_plugin/conftest.py`:
- Line 18: Replace the ineffective module-level pytestmark in conftest.py with a
pytest_collection_modifyitems hook that applies pytest.mark.flaky(reruns=0) to
all collected Console Plugin tests, ensuring the existing make target’s --reruns
3 setting is overridden for these tests.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 8eaec6b1-26db-4315-a7ad-4f84e0183ed7
📒 Files selected for processing (5)
Makefiletestsuite/tests/singlecluster/ui/console_plugin/conftest.pytestsuite/tests/singlecluster/ui/console_plugin/policies/dnstls/test_tls_policy.pytestsuite/tests/singlecluster/ui/console_plugin/policies/test_rate_limit_policy.pytestsuite/tests/singlecluster/ui/console_plugin/policies/test_token_rate_limit_policy.py
💤 Files with no reviewable changes (3)
- testsuite/tests/singlecluster/ui/console_plugin/policies/test_rate_limit_policy.py
- testsuite/tests/singlecluster/ui/console_plugin/policies/dnstls/test_tls_policy.py
- testsuite/tests/singlecluster/ui/console_plugin/policies/test_token_rate_limit_policy.py
Description
--reruns 3, every test burned ~4 minutes retrying, totaling ~68 minutes for 17 tests and potentially OOM-killing the CIcontainer
reruns=0in the shared UIconftest.pyand remove redundant per-test@pytest.mark.flaky(reruns=0)markersSummary by CodeRabbit