Skip to content

fix(rerun): turn off reruns for ui target - #1038

Merged
emmaaroche merged 1 commit into
Kuadrant:mainfrom
silvi-t:rerun-for-ui
Aug 11, 2026
Merged

fix(rerun): turn off reruns for ui target#1038
emmaaroche merged 1 commit into
Kuadrant:mainfrom
silvi-t:rerun-for-ui

Conversation

@silvi-t

@silvi-t silvi-t commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

  • Disable test reruns for all UI tests to prevent pipeline crashes caused by compounding 60-second Playwright timeouts
  • When the OpenShift console or plugin is unreachable, each UI test times out after 60s — with --reruns 3, every test burned ~4 minutes retrying, totaling ~68 minutes for 17 tests and potentially OOM-killing the CI
    container
  • Centralize reruns=0 in the shared UI conftest.py and remove redundant per-test @pytest.mark.flaky(reruns=0) markers

Summary by CodeRabbit

  • Tests
    • UI tests now run without automatic retries, providing more consistent reporting of test failures.
    • Retry configuration is applied centrally across the relevant UI test suite.
  • Chores
    • Updated the UI test command to disable pytest reruns while preserving all other behaviour.

Signed-off-by: Silvia Tarabova <starabov@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The ui Make target and console plugin tests now disable automatic pytest reruns. Redundant per-test reruns=0 markers were removed from policy tests.

Changes

UI test rerun control

Layer / File(s) Summary
Configure UI test reruns
Makefile, testsuite/tests/singlecluster/ui/console_plugin/conftest.py, testsuite/tests/singlecluster/ui/console_plugin/policies/...
The ui target and console plugin module disable automatic pytest reruns. TLS, rate-limit, and token rate-limit tests no longer use individual reruns=0 markers.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: averevki

Poem

A rabbit checks the test suite bright,
No reruns hide the first result tonight.
The UI path runs clear and true,
With markers trimmed from policies too.
Hop, hop—clean checks come through!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the purpose and implementation, but it omits the required Changes and Verification sections. Add the Changes and Verification sections, and document the test command or results used to validate the update.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows Conventional Commits format and clearly describes disabling reruns for the UI target.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@testsuite/tests/singlecluster/ui/console_plugin/conftest.py`:
- Line 18: Replace the ineffective module-level pytestmark in conftest.py with a
pytest_collection_modifyitems hook that applies pytest.mark.flaky(reruns=0) to
all collected Console Plugin tests, ensuring the existing make target’s --reruns
3 setting is overridden for these tests.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8eaec6b1-26db-4315-a7ad-4f84e0183ed7

📥 Commits

Reviewing files that changed from the base of the PR and between 01d9b45 and 2e7c306.

📒 Files selected for processing (5)
  • Makefile
  • testsuite/tests/singlecluster/ui/console_plugin/conftest.py
  • testsuite/tests/singlecluster/ui/console_plugin/policies/dnstls/test_tls_policy.py
  • testsuite/tests/singlecluster/ui/console_plugin/policies/test_rate_limit_policy.py
  • testsuite/tests/singlecluster/ui/console_plugin/policies/test_token_rate_limit_policy.py
💤 Files with no reviewable changes (3)
  • testsuite/tests/singlecluster/ui/console_plugin/policies/test_rate_limit_policy.py
  • testsuite/tests/singlecluster/ui/console_plugin/policies/dnstls/test_tls_policy.py
  • testsuite/tests/singlecluster/ui/console_plugin/policies/test_token_rate_limit_policy.py

Comment thread testsuite/tests/singlecluster/ui/console_plugin/conftest.py
@silvi-t
silvi-t requested a review from emmaaroche August 11, 2026 09:02
@emmaaroche
emmaaroche merged commit 80a3ede into Kuadrant:main Aug 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants