Interface cleanup#114
Closed
dennisreimann wants to merge 20 commits into
Closed
Conversation
This way one can directly call the `fadeMeOut` method on the actual view instead of having to call `[TSMessage dismissActiveNotification]` (which would be necessary if you want to dismiss the view programmatically in the callback, because you have disabled manual dismiss via `canBeDismissedByUser:NO`). I find it better to deal with the actual instance of the view rather than relying on it being the currently active notification. Right now it is only possible for it being the currently active notification, but these changes will make sense in conjunction with the next changes I'd like to propose in the next commits. ;)
Permanent notifications differ from normal ones in that permanent messages are not contained in the messages queue and can be displayed in addition to the other messages. Permanent notifications do not get dismissed automatically, hence they do not have a duration but have to be dismissed by the user or programmatically in one of the callbacks. The constructor for a permanent message also returns the instance of the message view, so that one can also capture it and dismiss it with other custom events.
This is so we can go forward and remove some of the incomplete edge case handling when calculating height and offset of the message view in `fadeInNotification:`, which depends on the statusbar and navigationbar being present or not. The demo project now works for all cases and shows the buttons to toggle statusbar and navigationbar.
notification -> message show -> display fadeOut -> dismiss
Owner
|
You Sir, are amazing! Thanks for the great contribution. I'm taking a look at those changes right now 👍 |
Owner
|
Points I noticed:
I guess it would also be fine to merge the following pull requests into the develop branch here:
I guess that would be a really nice 1.0 release:
|
Contributor
Author
Yes, I'll take care of this.
Yep. |
Contributor
Author
|
I've added the latest two commits on develop so that we can progress from there. This pull request won't need merging as its commits will be merged into master when we reach 1.0 on the develop branch and merge it from there. |
Contributor
Author
|
Hey @pengwynn, might this pull request be worth an Atom invite? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the changes I already talked to @KrauseFx about and want to propose to all of you so that we can talk about this interface cleanup.
Lots of breaking changes here, but I considered them necessary to support further development of TSMessages. It all started out with refactoring the initializers (0ae2927), which is also the biggest commit of this pull request. Another notable commit includes the naming changes (a614835) as well as dropping support for iOS 6 (cfb623d).
Feedback is welcome :)