Skip to content

test(integration): Use eventually to check listener's condition become RefNotResolved #7864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randmonkey merged 1 commit into from
Apr 29, 2026
+24 −18
Merged

test(integration): Use eventually to check listener's condition become RefNotResolved #7864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions test/integration/tlsroute_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ func TestTLSRoutePassthroughReferenceGrant(t *testing.T) {
t.Log("verifying that the tcpecho is responding properly over TLS")
require.Eventually(t, func() bool {
if err := tlsEchoResponds(proxyTLSURL, testUUID, tlsRouteHostname, certPool, true); err != nil {
t.Logf("failed accessing tcpecho at %s, err: %v", proxyTLSURL, err)
t.Logf("failed accessing tcpecho by SNI %s at %s, err: %v", tlsRouteHostname, proxyTLSURL, err)
return false
}
return true
Expand All @@ -275,8 +275,8 @@ func TestTLSRoutePassthroughReferenceGrant(t *testing.T) {
t.Log("verifying that the tcpecho route can also serve certificates permitted by a ReferenceGrant with a named To")
require.Eventually(t, func() bool {
if err := tlsEchoResponds(proxyTLSURL, testUUID2, tlsRouteExtraHostname, certPool, true); err != nil {
t.Logf("failed accessing tcpecho at %s, err: %v", proxyTLSURL, err)
return true
t.Logf("failed accessing tcpecho by SNI %s at %s, err: %v", tlsRouteExtraHostname, proxyTLSURL, err)
return false
}
return true
}, ingressWait, waitTick)
Expand All @@ -288,25 +288,31 @@ func TestTLSRoutePassthroughReferenceGrant(t *testing.T) {
require.NoError(t, err)

require.Eventually(t, func() bool {
return tlsEchoResponds(proxyTLSURL, testUUID2, tlsRouteExtraHostname, certPool, true) != nil
if err := tlsEchoResponds(proxyTLSURL, testUUID2, tlsRouteExtraHostname, certPool, true); err != nil {
t.Logf("failed accessing tcpecho by SNI %s at %s as expected, err: %v", tlsRouteExtraHostname, proxyTLSURL, err)
return true
}
t.Logf("Still can access tcpecho by SNI %s at %s", tlsRouteExtraHostname, proxyTLSURL)
return false
}, ingressWait, waitTick)

t.Log("verifying that a Listener has the invalid ref status condition")
gateway, err = gatewayClient.GatewayV1().Gateways(ns.Name).Get(ctx, gateway.Name, metav1.GetOptions{})
require.NoError(t, err)
invalid := false
for _, status := range gateway.Status.Listeners {
if ok := util.CheckCondition(
status.Conditions,
util.ConditionType(gatewayapi.ListenerConditionResolvedRefs),
util.ConditionReason(gatewayapi.ListenerReasonRefNotPermitted),
metav1.ConditionFalse,
gateway.Generation,
); ok {
invalid = true
require.Eventually(t, func() bool {
gateway, err = gatewayClient.GatewayV1().Gateways(ns.Name).Get(ctx, gateway.Name, metav1.GetOptions{})
require.NoError(t, err)
for _, status := range gateway.Status.Listeners {
if ok := util.CheckCondition(
status.Conditions,
util.ConditionType(gatewayapi.ListenerConditionResolvedRefs),
util.ConditionReason(gatewayapi.ListenerReasonRefNotPermitted),
metav1.ConditionFalse,
gateway.Generation,
); ok {
return true
}
}
}
require.True(t, invalid)
return false
}, ingressWait, waitTick)

t.Log("verifying the certificate returns when using a ReferenceGrant with no name restrictions")
grant.Spec.To[0].Name = nil
Expand Down
Loading