feat(graphic-walker): expose standalone PivotTable API and playground…#508
feat(graphic-walker): expose standalone PivotTable API and playground…#508ObservedObserver wants to merge 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 782ad3d0a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div className={className} style={style}> | ||
| <PivotTableImpl | ||
| key={pivotTableKey} | ||
| data={data} |
There was a problem hiding this comment.
The new standalone PivotTable passes data straight through to PivotTableImpl without running the aggregation pipeline (useRenderer/dataQuery) that the existing renderer path uses, so aggName on value fields is not actually applied for base cells. In datasets with multiple rows per row/column key (for example, repeated region + year pairs), buildMetricTableFromNestTree (components/pivotTable/utils.ts, where matched rows are reduced to a single record) will pick one row rather than computing sum/mean, yielding incorrect pivot values unless callers pre-aggregate manually.
Useful? React with 👍 / 👎.
1 participant
… example
Note
Cursor Bugbot is generating a summary for commit 782ad3d. Configure here.